Update piemod keymap #2786
Merged
Update piemod keymap #2786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
reviewed
Apr 21, 2018
| @@ -0,0 +1,77 @@ | |||
| SRC += matrix.c \ | |||
There was a problem hiding this comment.
You don't need all of this.
In fact, all you need is this block:
BOOTMAGIC_ENABLE = no # Virtual DIP switch configuration(+1000)
MOUSEKEY_ENABLE = yes # Mouse keys(+4700)
EXTRAKEY_ENABLE = yes # Audio control and System control(+450)
CONSOLE_ENABLE = no # Console for debug(+400)
COMMAND_ENABLE = yes # Commands for debug and configuration
NKRO_ENABLE = yes # Nkey Rollover - if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work
BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality
MIDI_ENABLE = no # MIDI controls
AUDIO_ENABLE = no # Audio output on port C6
UNICODE_ENABLE = yes # Unicode
BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID
RGBLIGHT_ENABLE = yes # Enable WS2812 RGB underlight. Do not enable this with audio at the same time.
SUBPROJECT_rev1 = no| @@ -109,7 +109,7 @@ int CAPSLOCKED = 0; | |||
| [3] = ACTION_LAYER_TAP_KEY(3, KC_E), // FN3 = Momentary numbEr layer on E. | |||
| [4] = ACTION_LAYER_TAP_KEY(4, KC_U), // FN4 = Momentary fUnction layer on U. | |||
| [5] = ACTION_LAYER_TAP_KEY(5, KC_Q), // FN5 = Momentary emaQs layer on Q. | |||
| [6] = ACTION_LAYER_TAP_KEY(6, KC_LCTRL), // FN6 = Momentary MACROS on ??? key. | |||
| [6] = ACTION_LAYER_TAP_KEY(6, KC_LCTRL), // FN6 = Momentary COMBOS on ??? key. | |||
There was a problem hiding this comment.
If you want, you could use LT(x, kc) in the keymap instead.
This accomplishes the same thing, but may look a bit cleaner.
Add RGB control, fix keymap to work with latest QMK.
Squashed commit of the following:
commit 3c5d95e4809d446fe5304aab9274d527182835e6
Author: dwrz <dwrz@dwrz.net>
Date: Sat Apr 21 18:26:58 2018 +0000
Make rules.mk for Let's Split piemod
commit 0cc5fc135220f0eb48509d2b027e4cad033d74a5
Author: dwrz <dwrz@dwrz.net>
Date: Sat Apr 21 18:26:25 2018 +0000
Add RGB control keys to function layer
commit d1b6bfa5f34123658534f99c97471b779b971ffb
Author: dwrz <dwrz@dwrz.net>
Date: Sat Apr 21 18:26:03 2018 +0000
Refactor MACROS to COMBOS
MACROS was conflicting with existing code.
commit ce2f47b13fb3bfab9d63292ddba466879d300051
Author: dwrz <dwrz@dwrz.net>
Date: Sat Apr 21 18:25:26 2018 +0000
Add typing options to config.h
commit cb0aa62b81a17aaaee1f9843138495b9ca14b6d4
Author: dwrz <dwrz@dwrz.net>
Date: Sat Apr 21 18:25:10 2018 +0000
Add RGB options to config.h
|
Thank you -- appreciate the insights. Really impressed by all the new work in QMK. |
drashna
reviewed
Apr 23, 2018
| // Special Keys | ||
| [10] = ACTION_MODS_KEY(KC_LCTRL, KC_LALT), // FN10 = Ctrl + Alt. | ||
|
|
||
| [1] = ACTION_MODS_KEY(KC_LCTRL, KC_LALT), // FN10 = Ctrl + Alt. |
There was a problem hiding this comment.
If these are doing what I think they're doing, then MT(mod, kc) handles this as well: https://docs.qmk.fm/features/advanced-keycodes#mod-tap
And it would be MT(MOD_LCTL, KC_LALT) and MT(MOD_LSFT, KC_SLSH) respectively.
No need to change this, unless you want.
There was a problem hiding this comment.
MT is another really cool addition I wasn't familiar with, but I don't think it's a drop in for this case. The functions are supposed to call both keys at the same time (e.g., to get a question mark for the latter).
If it's OK with you, I will follow-up with another pull request with some more functionality related changes.
There was a problem hiding this comment.
An, in that case, you'd just want these: https://docs.qmk.fm/keycodes#us-ansi-shifted-keys
|
Thanks! |
carlpehrson
pushed a commit
to carlpehrson/qmk_firmware
that referenced
this pull request
May 7, 2018
Add RGB control, fix keymap to work with latest QMK.
Squashed commit of the following:
commit 3c5d95e4809d446fe5304aab9274d527182835e6
Author: dwrz <dwrz@dwrz.net>
Date: Sat Apr 21 18:26:58 2018 +0000
Make rules.mk for Let's Split piemod
commit 0cc5fc135220f0eb48509d2b027e4cad033d74a5
Author: dwrz <dwrz@dwrz.net>
Date: Sat Apr 21 18:26:25 2018 +0000
Add RGB control keys to function layer
commit d1b6bfa5f34123658534f99c97471b779b971ffb
Author: dwrz <dwrz@dwrz.net>
Date: Sat Apr 21 18:26:03 2018 +0000
Refactor MACROS to COMBOS
MACROS was conflicting with existing code.
commit ce2f47b13fb3bfab9d63292ddba466879d300051
Author: dwrz <dwrz@dwrz.net>
Date: Sat Apr 21 18:25:26 2018 +0000
Add typing options to config.h
commit cb0aa62b81a17aaaee1f9843138495b9ca14b6d4
Author: dwrz <dwrz@dwrz.net>
Date: Sat Apr 21 18:25:10 2018 +0000
Add RGB options to config.h
hauleth
pushed a commit
to hauleth/qmk_firmware
that referenced
this pull request
Jan 24, 2019
Add RGB control, fix keymap to work with latest QMK.
Squashed commit of the following:
commit 3c5d95e4809d446fe5304aab9274d527182835e6
Author: dwrz <dwrz@dwrz.net>
Date: Sat Apr 21 18:26:58 2018 +0000
Make rules.mk for Let's Split piemod
commit 0cc5fc135220f0eb48509d2b027e4cad033d74a5
Author: dwrz <dwrz@dwrz.net>
Date: Sat Apr 21 18:26:25 2018 +0000
Add RGB control keys to function layer
commit d1b6bfa5f34123658534f99c97471b779b971ffb
Author: dwrz <dwrz@dwrz.net>
Date: Sat Apr 21 18:26:03 2018 +0000
Refactor MACROS to COMBOS
MACROS was conflicting with existing code.
commit ce2f47b13fb3bfab9d63292ddba466879d300051
Author: dwrz <dwrz@dwrz.net>
Date: Sat Apr 21 18:25:26 2018 +0000
Add typing options to config.h
commit cb0aa62b81a17aaaee1f9843138495b9ca14b6d4
Author: dwrz <dwrz@dwrz.net>
Date: Sat Apr 21 18:25:10 2018 +0000
Add RGB options to config.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add RGB control, fix keymap to work with latest QMK.
Squashed commit of the following:
commit 3c5d95e4809d446fe5304aab9274d527182835e6
Author: dwrz dwrz@dwrz.net
Date: Sat Apr 21 18:26:58 2018 +0000
commit 0cc5fc135220f0eb48509d2b027e4cad033d74a5
Author: dwrz dwrz@dwrz.net
Date: Sat Apr 21 18:26:25 2018 +0000
commit d1b6bfa5f34123658534f99c97471b779b971ffb
Author: dwrz dwrz@dwrz.net
Date: Sat Apr 21 18:26:03 2018 +0000
commit ce2f47b13fb3bfab9d63292ddba466879d300051
Author: dwrz dwrz@dwrz.net
Date: Sat Apr 21 18:25:26 2018 +0000
commit cb0aa62b81a17aaaee1f9843138495b9ca14b6d4
Author: dwrz dwrz@dwrz.net
Date: Sat Apr 21 18:25:10 2018 +0000